Oh, and of course, the inheritance is still there today: https://github.com/scikit-learn/scikit-learn/blob/f462edd741c3cbfccc1c6a2d64a2a66a6599d3f8/sklearn/base.py#L156

@microsoft-github-policy-service agree

stubs/sklearn/base.pyi:28:1: error: Call to untyped function "init_subclass" in typed context [no-untyped-call]
stubs/sklearn/naive_bayes.pyi:36:1: error: Call to untyped function "init_subclass" in typed context [no-untyped-call]
stubs/sklearn/naive_bayes.pyi:42:1: error: Call to untyped function "init_subclass" in typed context [no-untyped-call]
stubs/sklearn/naive_bayes.pyi:69:1: error: Call to untyped function "init_subclass" in typed context [no-untyped-call]

@Avasam, any idea why mypy is complaining here? I did a spot check and didn't see any explicit __init_subclass__ calls at the reported locations.

I'm omw out of city for the weekend. So I can't give you an exact detailed reason atm.
But that one can be triggered w/o an explicit call as mypy understand it is automatically called (I did have it come up in previous PRs).

It seems __init_subclass__ on _MetadataRequester creates the set_*_request() methods: https://github.com/scikit-learn/scikit-learn/blob/f462edd741c3cbfccc1c6a2d64a2a66a6599d3f8/sklearn/utils/_metadata_requests.py#L1406

However, the type stubs already have these methods statically on the class:

So, I think that means __init_subclass__ can be removed from the stubs? I don't think anyone will call it explicitly.

(I found another missing thing and added it in a new commit. Hope that's okay; I can remove it if not. It's about the global config: https://scikit-learn.org/stable/modules/generated/sklearn.set_config.html#sklearn.set_config )

Thanks for contribution @tmke8!